-
Notifications
You must be signed in to change notification settings - Fork 284
Fix mdadm.conf error message and add RHEL/CentOS notes #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated error message to use printf and added instructions for RHEL/CentOS.
|
Learn Build status updates of commit b37a2a0: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a shell scripting error and adds documentation for RHEL/CentOS-specific instructions related to NVMe temporary disk configuration. The change corrects an incorrect use of print to printf in a bash script and provides additional guidance for handling distribution-specific differences.
- Fixed
printcommand toprintfin bash script error handling - Added RHEL/CentOS-specific instructions for initramfs regeneration
- Added guidance for creating mdadm.conf file when missing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| exit 0 | ||
| ``` | ||
| For RHEL/CentOS based distributives, replace `update-initramfs -u` to `dracut --force` to regenerate initramfs file. |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'distributives' should be 'distributions'.
| For RHEL/CentOS based distributives, replace `update-initramfs -u` to `dracut --force` to regenerate initramfs file. | |
| For RHEL/CentOS based distributions, replace `update-initramfs -u` to `dracut --force` to regenerate initramfs file. |
| exit 0 | ||
| ``` | ||
| For RHEL/CentOS based distributives, replace `update-initramfs -u` to `dracut --force` to regenerate initramfs file. | ||
| If script stops execution with "Couldn't find mdadm.conf file", then you can create mdadm.conf file using commands: |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'using commands' is followed by a single command, not multiple commands. Consider changing to 'using command:' or 'using the following command:' for clarity.
| If script stops execution with "Couldn't find mdadm.conf file", then you can create mdadm.conf file using commands: | |
| If script stops execution with "Couldn't find mdadm.conf file", then you can create mdadm.conf file using the following command: |
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Updated error message to use printf and added instructions for RHEL/CentOS.