Skip to content

Conversation

@kaliti
Copy link

@kaliti kaliti commented Nov 3, 2025

Updated error message to use printf and added instructions for RHEL/CentOS.

Updated error message to use printf and added instructions for RHEL/CentOS.
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit b37a2a0:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/enable-nvme-temp-faqs.yml ✅Succeeded

For more details, please refer to the build report.

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.

@ttorble ttorble requested a review from Copilot November 3, 2025 15:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a shell scripting error and adds documentation for RHEL/CentOS-specific instructions related to NVMe temporary disk configuration. The change corrects an incorrect use of print to printf in a bash script and provides additional guidance for handling distribution-specific differences.

  • Fixed print command to printf in bash script error handling
  • Added RHEL/CentOS-specific instructions for initramfs regeneration
  • Added guidance for creating mdadm.conf file when missing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

exit 0
```
For RHEL/CentOS based distributives, replace `update-initramfs -u` to `dracut --force` to regenerate initramfs file.
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'distributives' should be 'distributions'.

Suggested change
For RHEL/CentOS based distributives, replace `update-initramfs -u` to `dracut --force` to regenerate initramfs file.
For RHEL/CentOS based distributions, replace `update-initramfs -u` to `dracut --force` to regenerate initramfs file.

Copilot uses AI. Check for mistakes.
exit 0
```
For RHEL/CentOS based distributives, replace `update-initramfs -u` to `dracut --force` to regenerate initramfs file.
If script stops execution with "Couldn't find mdadm.conf file", then you can create mdadm.conf file using commands:
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase 'using commands' is followed by a single command, not multiple commands. Consider changing to 'using command:' or 'using the following command:' for clarity.

Suggested change
If script stops execution with "Couldn't find mdadm.conf file", then you can create mdadm.conf file using commands:
If script stops execution with "Couldn't find mdadm.conf file", then you can create mdadm.conf file using the following command:

Copilot uses AI. Check for mistakes.
@ttorble
Copy link
Contributor

ttorble commented Nov 3, 2025

@ju-shim

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants