-
Notifications
You must be signed in to change notification settings - Fork 285
[SFMC][Maintenance Window] Document APIs for customers #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@iliu816 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit c917c19: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the documentation for Service Fabric managed cluster maintenance control by fixing grammar and spelling issues, and adding new sections for checking and manually applying maintenance windows.
- Corrected grammatical errors and improved clarity in the introduction section
- Fixed spelling inconsistencies ("everyday" → "every day", "5hours" → "5 hours")
- Added documentation for checking maintenance window status and manually applying maintenance windows
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Learn Build status updates of commit c917c19:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/service-fabric/how-to-managed-cluster-maintenance-control.md | Details |
articles/service-fabric/how-to-managed-cluster-maintenance-control.md
- Line 123, Column 63: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/rest/api/servicefabric/managedclusters/managed-maintenance-window-status/get' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. - Line 131, Column 170: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/rest/api/servicefabric/managedclusters/managed-apply-maintenance-window/post' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. - Line 123, Column 63: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/rest/api/servicefabric/managedclusters/managed-maintenance-window-status/get' will be broken in isolated environments. Replace with a relative link. - Line 131, Column 170: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/rest/api/servicefabric/managedclusters/managed-apply-maintenance-window/post' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
|
Learn Build status updates of commit 0bf51a5: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
|
Learn Build status updates of commit 3319f97: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Hi @LukeSlev - Thanks for your review. In the public repo, pull requests should be signed off by the author, another member of the content team, or a PM. @tomvcassidy Could you take a look? Thanks! |
|
@tomvcassidy Gentle bump on reviewing this PR |
Document APIs SFMC customers can use to get the status of their maintenance window and apply a maintenance window in the event of an activation failure.