Generalized SettingsWidgetFactory #6015
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Changed the forced WTable in SettingsWidgetFactory to WContainer to allow other containers to be used with it. (I mostly want this for my theme lol, but this gives a lot more freedom to themes).
Since DefaultSettingsWidgetFactory's group() method handles "table.row();" this was just a quick replace, so its shouldnt break anything 🙏
Edit: now that i thought about it, this is actually addon-breaking, since addons will have to do the same thing
Related issues
skill issue
How Has This Been Tested?
Singleplayer, main menu
This is how it looks after the change (table do be tabling):
Checklist: