Skip to content

Login speed improvement #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hlbmtc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Login speed improvement #3894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3d369d
Login speed improvement
hlbmtc Dec 9, 2025
753b768
Merge branch 'main' into feat/auth-speed-improvement
hlbmtc Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions authentication/views/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,9 @@ def login_api_view(request):
# The authenticate method below will return None for inactive users
# We want to show inactive users an error message so they can activate
# their account, and also to re-send their activation email
user = User.objects.filter(
Q(username__iexact=login) | Q(email__iexact=login)
).first()
user = AuthLoginBackend.find_user(login)

if user is not None and user.check_password(password) and not user.is_active:
if user and not user.is_active and user.check_password(password):
Copy link
Contributor Author

@hlbmtc hlbmtc Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elisescu user.check_password is expensive operation, so moved it to the end

send_activation_email(user, None)
raise ValidationError({"user_state": "inactive"})

Expand Down