Conversation
| #if !NOSOCKET | ||
| .AddSeeds(new[] | ||
| { | ||
| "178.128.221.177", |
There was a problem hiding this comment.
These seeds are for the main signet, I don't think it's correct to include them on a custom one.
On a custom signet the seed node would be the IP of the block-emitting node, which could be anything (a public IP, a LAN IP, etc).
| builder.SetChainName(name == DEFAULT_SIGNET_NAME ? SignetName : new ChainName(name)); | ||
| builder.SetNetworkSet(this); | ||
| builder.SetConsensus(new Consensus() | ||
| { |
There was a problem hiding this comment.
(GitHub doesn't allow me to comment on line 38 so I leave this comment here, the closest I could)
Bitcoin Knots supports -signetblocktime, which is a very useful flag for a custom signet. Maybe PowTargetSpacing could also be parameterized while keeping the default value of 10*60.
| private Network CreateSignet( | ||
| string name = DEFAULT_SIGNET_NAME, | ||
| string challenge = DEFAULT_SIGNET_CHALLENGE, | ||
| string genesisBlock = DEFAULT_SIGNET_GENESIS_BLOCK) |
There was a problem hiding this comment.
@NicolasDorier Understood, I'll take a look at this.
|
@sipsorcery sorry for the delay, I will follow more often to get this merge ASAP. I made a comment about it. @1ma same as your PR on #1295. You need to also fix the hashes. |
|
I merged #1295 so if you rebase, tests should pass. If you can do #1293 (comment) that would be perfect. |
|
@sipsorcery do you have some times to do #1293 (comment) ? |
I will but most likely not until the weekend. |
3 participants
As discussed in #1226.