Skip to content

Conversation

@orestiseth
Copy link
Contributor

@orestiseth orestiseth commented Oct 30, 2025

Note

Capitalize the displayed network name in the send form and replace FullScanSelectedAccounts with SyncSelectedAccounts that uses synchronize, updating routing, scheduling, and tests; bump manifest.

  • Handlers:
    • Replace CronMethod.FullScanSelectedAccounts with CronMethod.SyncSelectedAccounts and switch logic from accountsUseCases.fullScan to accountsUseCases.synchronize(account, 'metamask') in CronHandler.
    • Update request schema to SyncSelectedAccountsRequest and route handling to syncSelectedAccounts(...).
    • KeyringHandler.setSelectedAccounts now schedules background event with CronMethod.SyncSelectedAccounts.
  • UI:
    • Add displayNetwork(network) in infra/jsx/format.ts to capitalize network.
    • Use displayNetwork and adjust layout props (center) in UnifiedSendFormView.
  • Tests:
    • Update CronHandler.test.ts to reflect SyncSelectedAccounts and synchronize calls; keep full-scan single-account tests.
  • Manifest:
    • Bump packages/snap/snap.manifest.json version to 1.4.3 and update shasum.

Written by Cursor Bugbot for commit 14e7b47. This will update automatically on new commits. Configure here.

@orestiseth orestiseth marked this pull request as ready for review October 31, 2025 13:52
@orestiseth orestiseth requested a review from a team as a code owner October 31, 2025 13:52
cursor[bot]

This comment was marked as outdated.

@orestiseth orestiseth changed the title fix: capitalize network name fix: sync on setSelectedAccounts & fix network name format Oct 31, 2025
Copy link

@zone-live zone-live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orestiseth
Copy link
Contributor Author

Screenshot 2025-11-03 at 10 51 00 Screenshot 2025-11-03 at 10 50 50

@orestiseth orestiseth merged commit bce70db into main Nov 4, 2025
16 checks passed
@orestiseth orestiseth deleted the fix/capitalise-network-name branch November 4, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants