chore: swaps controller remove constants 2

[infiniteflower]

Description

This PR removes more constants imported from @metamask/swaps-controller.

Related to #23040

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Replaces swaps-controller chain ID constants with CHAIN_IDS from transaction-controller across bridge components, card logic/SDK, and tests.

• Bridge:
  • Replace chain constants with CHAIN_IDS in BridgeDestNetworksBar (update ChainPopularity, ShortChainNames).
  • Migrate allowed chains to CHAIN_IDS in utils/index.ts; adjust isBridgeAllowed and related tests.
• Card:
  • Use CHAIN_IDS.LINEA_MAINNET in useAssetBalances and useGetPriorityCardToken (including CAIP formatting) and update references accordingly.
  • Update CardSDK to derive lineaChainId from CHAIN_IDS.LINEA_MAINNET.
  • Revise associated tests to reference CHAIN_IDS and updated CAIP values.
• Selectors/Tests:
  • Update multichain EVM tests to use CHAIN_IDS for mainnet/polygon and related assertions.

^{Written by Cursor Bugbot for commit 9046975. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeTrade, SmokeCard
• Risk Level: low
• AI Confidence: 85%

click to see 🤖 AI reasoning details

This PR is a pure refactoring effort that migrates chain ID constant imports from @metamask/swaps-controller/dist/constants to @metamask/transaction-controller's CHAIN_IDS.

Analysis Summary:

1. Nature of Changes: The changes replace constant imports and their usages across 11 files:

   • Bridge components (3 files): BridgeDestNetworksBar, Bridge utils
   • Card components (7 files): CardHome, useAssetBalances, useGetPriorityCardToken, CardSDK, and related tests
   • Multichain selectors (1 file): EVM selector tests

2. Functional Impact: This is a like-for-like constant replacement with no functional changes:

   • ETH_CHAIN_ID → CHAIN_IDS.MAINNET
   • LINEA_CHAIN_ID → CHAIN_IDS.LINEA_MAINNET
   • BSC_CHAIN_ID → CHAIN_IDS.BSC
   • And similar mappings for other chains (Base, Arbitrum, Polygon, etc.)

3. Test Coverage: All affected test files have been updated accordingly, including mocks that were referencing the old constants.

4. Risk Assessment: Low risk because:

   • No logic changes, only import path and constant name changes
   • Constants represent the same values (chain IDs)
   • Comprehensive unit test updates included
   • This is a standard refactoring pattern

Test Tag Selection Rationale:

• SmokeTrade: Selected because Bridge functionality is part of the trading/DEX flow, and the Bridge components were modified
• SmokeCard: Selected because 7 out of 11 files are related to Card functionality (hooks, SDK, views, utils)

These two tags provide targeted coverage of the affected functional areas. While the risk is low due to the refactoring nature, running these specific smoke tests ensures the Bridge and Card features continue to work correctly with the new constant imports.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[infiniteflower]

This is actually a different value from before. The field is caipChainId but a hex value was incorrectly being passed in before (TS did not complain for some reason). The new value is actually a CAIP chain id now.

[GeorgeGkas]

lgtm