Skip to content

Pooled Staking Deposit With Delegation #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Pooled Staking Deposit With Delegation #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
48a9279
feat: adding basic pooled staking deposit with delegation
hanzel98 Jun 19, 2025
3341fff
test: forks for deposit, exit, claim
hanzel98 Jun 24, 2025
8fa2b75
Merge branch 'main' into feat/pooled-staking
hanzel98 Jun 24, 2025
604187b
Merge branch 'main' into feat/pooled-staking
hanzel98 Jul 2, 2025
7670833
chore: added coverage fix, and sorting imports
hanzel98 Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 93 additions & 4 deletions script/coverage.sh
View file
Open in desktop
Copy link
Contributor

@MoMannn MoMannn Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any docs how to run this script?

Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,106 @@ cd ..
folder_path="coverage"

if [ ! -d "$folder_path" ]; then
# If not, create the folder
mkdir -p "$folder_path"
echo "Folder created at: $folder_path"
else
echo "Folder already exists at: $folder_path"
fi

# Configuration: Define test files for different EVM versions
declare -a SHANGHAI_TESTS=(
# "test/helpers/LiquidStaking.t.sol"
test/helpers/PooledStaking.t.sol
# Add more shanghai tests here in the future
# "test/helpers/AnotherShanghaiTest.t.sol"
)

declare -a CANCUN_TESTS=(
# Add cancun tests here when needed
# "test/helpers/CancunTest.t.sol"
)

# Generates lcov.info
forge coverage --report lcov --skip scripts --report-file "$folder_path/lcov.info"
# Function to build match patterns for forge coverage
build_match_patterns() {
local tests=("$@")
local patterns=""

for test in "${tests[@]}"; do
if [[ -n "$patterns" ]]; then
patterns="$patterns --match-path *$(basename "$test")"
else
patterns="--match-path *$(basename "$test")"
fi
done

echo "$patterns"
}

# Function to build no-match patterns for forge coverage
build_no_match_patterns() {
local tests=("$@")
local patterns=""

for test in "${tests[@]}"; do
if [[ -n "$patterns" ]]; then
patterns="$patterns --no-match-path *$(basename "$test")"
else
patterns="--no-match-path *$(basename "$test")"
fi
done

echo "$patterns"
}

echo "Running coverage with inline EVM version flags..."
echo "-----------------------------------------------"

# Build list of all special EVM tests to exclude from default London run
ALL_SPECIAL_EVM_TESTS=("${SHANGHAI_TESTS[@]}" "${CANCUN_TESTS[@]}")
LONDON_NO_MATCH_PATTERNS=$(build_no_match_patterns "${ALL_SPECIAL_EVM_TESTS[@]}")

# Generate coverage for London EVM (default) - exclude special EVM tests
if [[ -n "$LONDON_NO_MATCH_PATTERNS" ]]; then
echo "Running coverage for London EVM..."
echo "Excluding: ${ALL_SPECIAL_EVM_TESTS[*]}"
forge coverage --evm-version london --report lcov --skip scripts $LONDON_NO_MATCH_PATTERNS --report-file "$folder_path/lcov-london.info"
else
echo "Running coverage for London EVM - no exclusions..."
forge coverage --evm-version london --report lcov --skip scripts --report-file "$folder_path/lcov-london.info"
fi

# Generate coverage for Shanghai EVM tests if any exist
if [ ${#SHANGHAI_TESTS[@]} -gt 0 ]; then
echo "Running coverage for Shanghai EVM..."
echo "Including: ${SHANGHAI_TESTS[*]}"
SHANGHAI_MATCH_PATTERNS=$(build_match_patterns "${SHANGHAI_TESTS[@]}")
forge coverage --evm-version shanghai --report lcov --skip scripts $SHANGHAI_MATCH_PATTERNS --report-file "$folder_path/lcov-shanghai.info"
fi

# Generate coverage for Cancun EVM tests if any exist
if [ ${#CANCUN_TESTS[@]} -gt 0 ]; then
echo "Running coverage for Cancun EVM..."
echo "Including: ${CANCUN_TESTS[*]}"
CANCUN_MATCH_PATTERNS=$(build_match_patterns "${CANCUN_TESTS[@]}")
forge coverage --evm-version cancun --report lcov --skip scripts $CANCUN_MATCH_PATTERNS --report-file "$folder_path/lcov-cancun.info"
fi

# Build the list of coverage files to merge
COVERAGE_FILES=("$folder_path/lcov-london.info")
if [ ${#SHANGHAI_TESTS[@]} -gt 0 ]; then
COVERAGE_FILES+=("$folder_path/lcov-shanghai.info")
fi
if [ ${#CANCUN_TESTS[@]} -gt 0 ]; then
COVERAGE_FILES+=("$folder_path/lcov-cancun.info")
fi

# Merge the lcov files
echo "Merging coverage reports..."
echo "Files to merge: ${COVERAGE_FILES[*]}"
lcov \
--rc branch_coverage=1 \
$(printf -- "--add-tracefile %s " "${COVERAGE_FILES[@]}") \
--output-file "$folder_path/lcov.info"

# Filter out test, mock, and script files
lcov \
Expand All @@ -39,4 +128,4 @@ then
--output-directory "$folder_path" \
"$folder_path/filtered-lcov.info"
open "$folder_path/index.html"
fi
fi
Loading
Loading