Relaxed complier version - Fixes #88 #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Set compiler version to be
^0.8.23instead of0.8.23Fixes #88
Why?
When importing the delegation framework into the Foundry project, having a locked compiler version is problematic. The project will not compile if it imports other third-party contracts that use a higher version of Solidity, such as
0.8.27.For instance, if a project imports both rhineston's module kit and the delegation framework, the project will not compile as most contracts in the module kit use
^0.8.27and the delegation framework has locked compiler version0.8.23.Foundry does not support using multiple compiler versions in the same project.
How?
Allowed using compiler versions
0.8.23or higher.