Conversation
yaswant
reviewed
Feb 13, 2026
Collaborator
There was a problem hiding this comment.
The artifact is still uploaded from ./mule/docs/build/html so I am not sure how that would work! You probably forgot to replace ./mule/docs/build/html with .github/files in the upload-pages-artifact step?
we need to upload:
somewhere (we have the built docs for both mule and um_utils that will be uploaded)
├── index.html
├── mule
└── um_utils
Collaborator
Author
Thanks Yash - might have made more sense if I'd remembered to update the artifact upload path! But agree we don't need to store the index.html file, so updated that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Code Reviewer: @yaswant
It's been pointed out that the um_utils docs aren't included in the gh-pages deployment. They're built by the workflow but not deployed. This corrects that.
It also changes the workflow to only upload the artifact if this is a push to main.
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
Testing
acceptable (eg. kgo changes)
tests, unit tests, etc.)
trac.log
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Code Review