Modify METPlus apps to facilitate using at multiple sites#1906
Modify METPlus apps to facilitate using at multiple sites#1906JorgeBornemann wants to merge 1 commit intomainfrom
Conversation
|
|
There was a problem hiding this comment.
Gone to restricted files repo
There was a problem hiding this comment.
Gone to restricted files repo
JorgeBornemann
changed the title
|
must be merged concurrently with https://github.com/MetOffice/CSET-restricted-files/pull/216 |
Sylviabohnenstengel
left a comment
Sylviabohnenstengel
left a comment
There was a problem hiding this comment.
happy to approve though suggest that @jfrost-mo has a further technical look through
jfrost-mo
changed the title
jfrost-mo
left a comment
jfrost-mo
left a comment
There was a problem hiding this comment.
A few minor suggestions; the main one is to use isodatetime for parsing the forecast duration into hours. Otherwise looks good and happy to merge.
There was a problem hiding this comment.
With these files now under a site-specific directory, we don't need the site in the filename.
While we are at it, do we want to update any of these references to NIWA to ESNZ before it goes in? I'll leave it up-to-you.
There was a problem hiding this comment.
Agreed. I am still awaiting a bit of clarification on the site. maybe ESNZ will not be suitable, as I think our domain name will be NZIES (New Zealand Institute for Earth Sciences). So we can change names and remove the redundant info in a later ticket?
| METPLUS_ANA_DIR = {{METPLUS_ANA_DIR}} | ||
| METPLUS_FCST_DIR = {{METPLUS_FCST_DIR}} | ||
| METPLUS_OBS_DIR = {{METPLUS_OBS_DIR}} | ||
| ROSE_APP_OPT_CONF_KEYS = {{METPLUS_OPT_CONFIG_KEYS}} |
There was a problem hiding this comment.
Are these settings defined (even if to "") when METplus is not enabled in the rose-suite.conf? Or are they trigger ignored?
There was a problem hiding this comment.
Thanks, good point, they are used by point_stat and grid_stat. I don't know why they were coded only for grid_stat, and that is why I removed the check, but I can see it can break things outside NIWA.
There was a problem hiding this comment.
I put them in a includes/metplus_common.cylc file with the relevant logicals.
3 participants
Implements #971. This PR restores MET functionality at NIWA after migration to new HPC and changes in the bake tasks schedulling, it also sets the infrastructure to start adding other site-specific METPlus configurations,
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.