Enable user to specify CMIP runs in addition to model development runs#358
Open
NParsonsMO wants to merge 41 commits intomainfrom
Open
Enable user to specify CMIP runs in addition to model development runs#358NParsonsMO wants to merge 41 commits intomainfrom
NParsonsMO wants to merge 41 commits intomainfrom
Conversation
NParsonsMO
changed the title
NParsonsMO
commented
Feb 10, 2026
| write_dict_to_yaml(datasets, target_fp) | ||
|
|
||
|
|
||
| def dict_namelists_in_grandparent_dir(): |
Collaborator
Author
There was a problem hiding this comment.
Consider whether this comment is relevant to the current approach:
#349 (comment)
NParsonsMO
commented
Feb 11, 2026
Collaborator
Author
There was a problem hiding this comment.
I tried to copy the style from test_update_recipe_file.py, but wasn't really sure what I was doing, so maybe this is not great...
NParsonsMO
commented
Feb 13, 2026
| write_recipe(updated_recipe, recipe_path) | ||
|
|
||
| # Add the CMIP6 datasets to the recipe | ||
| cmip6_datasets_fp = f"{os.environ['DATASETS_LIST_DIR']}/cmip6_datasets.yml" |
Collaborator
Author
There was a problem hiding this comment.
The file is made by rose even if there are no datasets in it
NParsonsMO
commented
Feb 13, 2026
Collaborator
Author
There was a problem hiding this comment.
I want to put START_YEAR and NUMBER_OF_YEARS in here instead of the main rose-suite.conf, but currently it's needed there for the main model runs and it would be confusing to have it twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130.
PR creation checklist for the developer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?I didn't add the user story one either.
Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the developer
docdirectory) related to the change been updated appropriately, including the Quick Start section?PR creation checklist for the reviewer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the reviewer
docdirectory) related to the change been updated appropriately, including the Quick Start section?