Attempt to refactor old Mesh proper as an API #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Fabric version from 1.18 to 1.19. It's not a perfect conversion, many of the things which are not necessarily trivial to fix while changing the version haven't been implemented. It also refactors stuff so that it'll function as a mod. Forge 1.12 has not been refactored or made to fit as the loader doesn't yet support it - it shouldn't collide with the build though. I haven't implemented too many changes besides just getting it to build - changes relating to how we approach the API and its coverage can come later.
Currently it build successfully (on my end), but it will not load; I am not sure what is causing the loading to fail. @Tigermouthbear perhaps you can figure it out?