fix ogimage unique constraint on resource registration#642
Open
285729101 wants to merge 1 commit intoMerit-Systems:mainfrom
Open
fix ogimage unique constraint on resource registration#642285729101 wants to merge 1 commit intoMerit-Systems:mainfrom
285729101 wants to merge 1 commit intoMerit-Systems:mainfrom
Conversation
Contributor
|
@285729101 is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@jasonhedman this fixes a race condition in the OG image generation — deduplicates and processes sequentially to avoid the unique constraint violation. Would appreciate a review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the unique constraint conflict when registering resources whose origins share OG image URLs.
The
Promise.allupsert could race on the same(originId, url)composite key when the scraped HTML contains duplicateog:imagetags. This deduplicates images by URL first (last wins, matching browser behaviour), then upserts them sequentially inside the existing transaction.Closes #287