merge queue: checking main (d3bb739) and #12391 together - #12392
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: checking main (d3bb739) and #12391 together#12392mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
The GitHub App the Enterprise installer creates has no logo, so Mergify's check runs render with GitHub's default placeholder on every pull request of every self-hosted install. Nothing in the Enterprise guide mentioned it, so admins had no reason to know it was theirs to fix. Add a "Set the GitHub App Logo" section to the installation guide, right after the App is created and installed, plus a pointer to it from the legacy manual-installation page. It covers where an org-owned App's settings page lives on either github.com or a GHES host, the Display information -> Upload a logo -> crop -> Set new avatar flow, the file constraints, and the Badge background color field that only shows up once a logo is uploaded. The section says in one sentence why this is manual, so nobody goes looking for an API: GitHub's App manifest rejects any image field, and an App registration cannot be modified through the API after creation. Ship a square asset for admins to upload: public/mergify-github-app-logo.png, a 200x200 PNG of the Mergify mark matching the one the hosted App uses, so self-hosted checks look like the hosted ones. The installer's vendored wordmark is 1024x275 and crops badly, so it is not usable here. MRGFY-418 Change-Id: Ia11c411bad8e7bab1e7ae933961e751e70099fd9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (d3bb739) and #12391 are queued together for merge.
This pull request has been created by Mergify to check the mergeability of #12391.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]schedule=Mon-Fri 09:00-17:30[Europe/Paris]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/Required conditions to stay in the queue:
github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/author != dependabot[bot]author != mergify-ci-bothead ~= ^docs-agent/