Ya/fix nimo nav#3265
Draft
aisraelov wants to merge 7 commits into
Draft
Conversation
Revert the host-side webviewFillsNavBar hack (LocalMiniappView + miniappGlobals back to dev). Padding every local miniapp's <body> both double-counted the inset for the miniapps that already handle it via useSafeArea(), and did nothing for Maps — whose bottom UI is position:fixed, which body padding never moves. So it neither fixed Maps nor was safe for the others. Fix Maps itself, the way the other miniapps do: consume the host-injected --mentra-safe-bottom inset on the bottom-anchored overlay UI so it clears the Android 3-button nav bar, while the Mapbox canvas stays full-bleed under the bars. - Drawer / NavigationRunningDrawer: pad the OUTER fixed wrapper by the inset (not the measured card, so peek/drag math is unchanged). - NavMap right-rail: anchor above the inset as well as the drawer. - Toast + search-results list: lift/pad by the inset. - Bump miniapp version 1.1.7 -> 1.1.8. NOTE: the bundled zip in mobile/assets/miniapps/ must be repacked (mentra-miniapp release, with PUBLIC_MAPBOX_TOKEN / PUBLIC_MAP_NAV_VIEWER set) and bundledMiniapps regenerated for this to ship at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Improved Nimo navigation HUD and pairing reliability on Android and iOS, and fixed iOS audio by switching to the system Opus decoder. Mentra Maps now respects the Android 3‑button navbar; Cloud V2 defaults to debug.
New Features
Bug Fixes
retrieveConnectedPeripherals, match nameless UART‑service adverts, and auto‑connect after Settings pairing; app pairing now completes on the BLE connection (added Nimo to classic flow).--mentra-safe-bottomin Drawer, RunningDrawer, Toast, right‑rail, and search results so Maps clears the 3‑button navbar; bump miniapp to 1.1.8. Requires re‑bundling Maps assets.setTimehandshake retry; Nimo is no longer super‑mode only; default Cloud V2 URLs todebug.Written for commit 9e2fcde. Summary will update on new commits.