fix: align generated skill guidance#2100
Conversation
shinetata
left a comment
There was a problem hiding this comment.
Approve — LGTM.
Aligns the generated SKILL.md guidance with #1423: concise 2-4 word kebab-case name, name+description-only frontmatter, progressive disclosure for multi-variant skills, and no auxiliary docs.
I looked closely at the one change that seemed risky — removing the metadata: { "openclaw": { "emoji": "{emoji}" } } line. It's safe: the {emoji} placeholder was never substituted in step1GenerateSkillMd (the replace chain only fills NAME/TITLE/SUMMARY/CONVERSATION), and no runtime code consumes that field. So this drops a dead placeholder rather than a working feature, and it satisfies the "name + description only" rule. No impact on the core memory pipeline (capture/ingest/embed/recall) — skill retrieval keys off name + description only.
Verified locally with the project-pinned vitest 2.1.9: tests/skill-prompt-policy.test.ts -> 3 passed (incl. the new case). CI is green across all 16 build jobs.
Nit (non-blocking): only the apps/memos-local-openclaw copy has the policy test; the identical packages/memos-core copy isn't covered. Consider adding a matching test or extracting a shared constant to prevent future drift between the two copies.
🤖 Open Code ReviewTarget: PR #2100 ✅ OpenCodeReview: No comments generated. Looks good to me. Generated by cloud-assistant via Open Code Review. |
|
Description
Fixes #1423.
Aligns generated
SKILL.mdguidance with the requested skill-creator practices:nameanddescriptionSKILL.mdwhile moving variant details toreferences/No dependencies are added.
Type of change
How Has This Been Tested?
cd apps/memos-local-openclaw && npm test -- --run tests/skill-prompt-policy.test.ts(3 passed)cd apps/memos-local-openclaw && npm run buildgit diff --checkLocal limitations:
npm run lintcannot start because this package does not declare or installeslint;make formatcannot start because Poetry is unavailable in this environment.Checklist
Reviewer Checklist