Skip to content

fix: align generated skill guidance#2100

Open
RerankerGuo wants to merge 2 commits into
MemTensor:dev-v2.0.24from
RerankerGuo:fix/skill-generator-guidance
Open

fix: align generated skill guidance#2100
RerankerGuo wants to merge 2 commits into
MemTensor:dev-v2.0.24from
RerankerGuo:fix/skill-generator-guidance

Conversation

@RerankerGuo

@RerankerGuo RerankerGuo commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #1423.

Aligns generated SKILL.md guidance with the requested skill-creator practices:

  • require concise two-to-four-word kebab-case names and trigger-aware descriptions
  • limit frontmatter to name and description
  • keep shared workflows in SKILL.md while moving variant details to references/
  • avoid redundant trigger sections and standalone auxiliary documentation
  • keep the OpenClaw and core generator copies aligned

No dependencies are added.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Unit Test
    • cd apps/memos-local-openclaw && npm test -- --run tests/skill-prompt-policy.test.ts (3 passed)
  • Test Script Or Test Steps
    • cd apps/memos-local-openclaw && npm run build
    • static policy checks against both generator copies
    • git diff --check
  • Pipeline Automated Test
    • GitHub Actions passed all 16 build jobs across macOS, Ubuntu, Windows, and Python 3.10-3.13

Local limitations: npm run lint cannot start because this package does not declare or install eslint; make format cannot start because Poetry is unavailable in this environment.

Checklist

  • I have performed a self-review of my own code | 我已自行检查了自己的代码
  • I have commented my code in hard-to-understand areas | 我已在难以理解的地方对代码进行了注释
  • I have added tests that prove my fix is effective or that my feature works | 我已添加测试以证明我的修复有效或功能正常
  • I have created related documentation issue/PR in MemOS-Docs (not applicable; no documentation change)
  • I have linked the issue to this PR | 我已将 issue 链接到此 PR
  • I have mentioned the person who will review this PR: @bittergreen

Reviewer Checklist

@RerankerGuo
RerankerGuo marked this pull request as ready for review July 13, 2026 05:27
@CarltonXiang CarltonXiang added the area:plugin OpenClaw & Hermes label Jul 14, 2026
@Memtensor-AI
Memtensor-AI changed the base branch from main to dev-v2.0.24 July 14, 2026 02:48
@Memtensor-AI
Memtensor-AI changed the base branch from dev-v2.0.24 to main July 14, 2026 02:48
@shinetata
shinetata changed the base branch from main to dev-v2.0.24 July 16, 2026 04:57

@shinetata shinetata left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — LGTM.

Aligns the generated SKILL.md guidance with #1423: concise 2-4 word kebab-case name, name+description-only frontmatter, progressive disclosure for multi-variant skills, and no auxiliary docs.

I looked closely at the one change that seemed risky — removing the metadata: { "openclaw": { "emoji": "{emoji}" } } line. It's safe: the {emoji} placeholder was never substituted in step1GenerateSkillMd (the replace chain only fills NAME/TITLE/SUMMARY/CONVERSATION), and no runtime code consumes that field. So this drops a dead placeholder rather than a working feature, and it satisfies the "name + description only" rule. No impact on the core memory pipeline (capture/ingest/embed/recall) — skill retrieval keys off name + description only.

Verified locally with the project-pinned vitest 2.1.9: tests/skill-prompt-policy.test.ts -> 3 passed (incl. the new case). CI is green across all 16 build jobs.

Nit (non-blocking): only the apps/memos-local-openclaw copy has the policy test; the identical packages/memos-core copy isn't covered. Consider adding a matching test or extracting a shared constant to prevent future drift between the two copies.

@Memtensor-AI Memtensor-AI added the status:in-progress Someone or AI is working on it | 人工或 AI 正在处理 label Jul 16, 2026
@Memtensor-AI
Memtensor-AI requested review from hijzy and whipser030 July 16, 2026 05:02
@Memtensor-AI

Copy link
Copy Markdown
Collaborator

🤖 Open Code Review

Target: PR #2100
Task: 160b279b7ccb7705
Base: dev-v2.0.24
Head: fix/skill-generator-guidance

OpenCodeReview: No comments generated. Looks good to me.

Generated by cloud-assistant via Open Code Review.

@Memtensor-AI

Copy link
Copy Markdown
Collaborator

⚠️ Automated Test Results: ENV ISSUE

The test environment encountered an issue that requires manual attention.

Details: Test failures are caused by a SQLite migration error where the 'traces' table is missing a 'role' column, which is unrelated to the diff (which only modifies skill generator prompt templates). [advisory, non-gating] AI-generated tests on branch test/auto-gen-160b279b7ccb7705-20260716130904: 113/113 passed — these do NOT affect the PR verdict; review the branch manually.
Branch: fix/skill-generator-guidance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:plugin OpenClaw & Hermes status:in-progress Someone or AI is working on it | 人工或 AI 正在处理

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Skill generation template does not follow skill-creator best practices

5 participants