SJH 3.0: Replace BiPredicate by UnionPathFilter in UnionFS and hide SecureJar impl details #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matyrobbrt
added
enhancement
…ecureJar impl details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two breaking changes:
UnionPathFilterwas introduced in RefactorSecureJarimplementation and add package exclusions #47 forJarContentsBuilder. This PR replaces the remaining uses of theBiPredicate<String, String>. (Except for theSecureJar.fromoverloads because they don't hurt to keep - and FML is still using them).cpw.mods.jarhandling.implpackage - its impl details should not be exposed to the outside world.This is a breaking change and needs to be merged manually to apply the
3.0tag.Tested on ATM9 and it still works - this is not actually a breaking change for our usage in NeoForge.