Skip to content

Dockerfiles: Make python always execute python3 #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minosgalanakis wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dockerfiles: Make python always execute python3 #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae95441
Dockerfiles: Make python always execute python3
minosgalanakis Jan 9, 2026
b4153a9
arm-compiler/16.04 Dockerfiles: Make python always execute python3
minosgalanakis Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions resources/docker_files/arm-compilers/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ RUN apt-get update -q && apt-get install -yq \
python3-pip \
# to install several Python packages (done by individual jobs)
python3-venv \
# make `python` invoke `python3`
python-is-python3 \
# to download things installed from other places
wget \
&& rm -rf /var/lib/apt/lists/
Expand Down
3 changes: 3 additions & 0 deletions resources/docker_files/ubuntu-16.04/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,9 @@ RUN wget -q https://github.com/lvc/abi-compliance-checker/archive/2.3.tar.gz &&
RUN git clone --branch 1.1 https://github.com/lvc/abi-dumper.git && \
cd abi-dumper && make install prefix=/usr && cd .. && rm -rf abi-dumper

# Make python point to python3
RUN ln -sf /usr/local/bin/python3 /usr/local/bin/python

# Add user
RUN useradd -m user

Expand Down
3 changes: 3 additions & 0 deletions resources/docker_files/ubuntu-18.04/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,9 @@ RUN python3 -m pip install 'pip<22' --upgrade | cat && \
python3 -m pip install setuptools --upgrade && \
true

# Make python point to python3
RUN ln -sf /usr/bin/python3 /usr/local/bin/python

@gilles-peskine-arm gilles-peskine-arm Jan 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needed on 16.04 (but we want /usr/local/bin/python3 there, not /usr/bin/python3 which is too old).


# Add user
RUN useradd -m user

Expand Down
2 changes: 2 additions & 0 deletions resources/docker_files/ubuntu-24.04/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ RUN apt-get update -q && apt-get install -yq \
python3-setuptools \
# to install several Python packages (done by individual jobs)
python3-venv \
# make `python` invoke `python3`
python-is-python3 \

@gilles-peskine-arm gilles-peskine-arm Jan 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our script files we use python e.g link and python3 e.g. link interchangeably.

Historically, we used python3, not python, because during the python2→python3 transition, python was often python2. I don't know if that's still relevant in 2026, however. Ubuntu 20.04 was the last Ubuntu LTS where /usr/bin/python being Python 2 was officially supported. What about other OSes? What's /usr/bin/python on macOS these days?

Even if it's ok to no longer care about Python 2, I don't think we should use python3 and python interchangeably. That just makes things harder. Even if Python 2 is not available, python and python3 could be different versions of Python 3.x on some systems.

@gilles-peskine-arm gilles-peskine-arm Jan 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for make_generates_files.py: Mbed-TLS/mbedtls-framework#270

@gilles-peskine-arm gilles-peskine-arm Jan 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needed on arm-compilers.

# provides some useful scripts for adding and removing repositories
software-properties-common \
# for test_driver.py (since TF-PSA-Crypto 1.1)
Expand Down