Fix performance by caching Calendar.autoupdatingCurrent #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, avoiding constantly reinstantiating it (which is a performance hit when performing multiple consecutive Date manipulations)
…d reading an incorrect number of hours apart.
Contributor
Author
|
Hi @MatthewYork, thought I should call attention to this again. It's a pretty simple but performance-increasing fix. I accidentally included these commits in my PR #256 (now closed) for a different issue. |
… but the day component is 2 apart. (Example: April 19, 10PM and April 21, 2PM)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @MatthewYork! I recently discovered a performance problem when performing a lot of date calculations in a row, which boils down to the fact that initializing
Calendar.autoupdatingCurrentis a somewhat expensive operation. This PR simplifies things by simply keeping a static copy ofCalendar.autoupdatingCurrentonDateand using it everywhere. I had an operation that was taking 8 seconds drop to <1 second with this fix.