Skip to content

Tutorial#96

Merged
eimrek merged 1 commit into
mainfrom
tutorial
Apr 22, 2026
Merged

Tutorial#96
eimrek merged 1 commit into
mainfrom
tutorial

Conversation

@eimrek

@eimrek eimrek commented Apr 20, 2026

Copy link
Copy Markdown
Member

A jupyter notebook based tutorial, that contains source data, explains it, and start the API.

The jupyter code blocks are only used to demonstrate python-based querying to the running API that needs to be started on the background.

Uses the dir-entry-paths PR to contain a directory of cif files -- easier for users to open it up, and inspect the source files.

Added a note to README as well.

Let me know what you think of this @ml-evs. Happy to adapt as you think makes sense.

@eimrek eimrek requested a review from ml-evs as a code owner April 20, 2026 21:35

@ml-evs ml-evs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @eimrek! Again looks great and would be happy to pull the trigger already.

Minor thoughts:

  • We could include running optimake convert as a shell command in the notebook as !optimake convert and maybe even !optimake serve & would also work?
  • This would let us run this notebook directly in the CI (using nbval) but perhaps this isn't necessary as the example will already be tested.

Base automatically changed from dir-entry-paths to main April 22, 2026 22:12
@eimrek

eimrek commented Apr 22, 2026

Copy link
Copy Markdown
Member Author

thanks @ml-evs! I tried to use !optimake serve & but wasn't able to get it to work in a notebook. I wasn't sure about where to mention optimake convert, as it's not strictly necessary for the use case the tutorial demonstrates. But feel free to add it and also any testing, as you think is best. Happy to review :)

@eimrek eimrek merged commit b6f5eef into main Apr 22, 2026
4 checks passed
@eimrek eimrek deleted the tutorial branch April 22, 2026 22:21
@ml-evs

ml-evs commented Apr 22, 2026

Copy link
Copy Markdown
Member

I'm happy if you're happy! Have we just reached v1.0???

@eimrek

eimrek commented Apr 23, 2026

Copy link
Copy Markdown
Member Author

Have we just reached v1.0???

We might just have! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants