ci: Fix benchmark version overrides crudely #34035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by MaterializeInc#34021 > builtins.AssertionError: Expected materialize/materialized:v0.164.0-dev.0--main.gc28d0061a6c9e63ee50a5f555c5d90373d006686 to be of profile RELEASE, but found OPTIMIZED instead. Consider passing `--release` or `--optimized` to `mzcompose` explicitly. Set CI_IGNORE_BUILD_PROFILE=1 if you don't care about comparability of benchmark results. Seen in https://buildkite.com/materialize/nightly/builds/13985#019a53a4-7545-4043-8a33-7d85ad85023d The root cause is that we now use LTO Release builds only for releases + nightly, not for normal test runs. So the tagged runs from test pipeline are all Optimized builds, comparing against them for performance doesn't make sense.
Contributor
Author
|
Ready for review, this is currently causing Nightly on main to be red. |
SangJunBak
reviewed
Nov 7, 2025
Comment on lines
248
to
+249
| # use the commit instead of the latest release | ||
| return ( | ||
| commit_to_image_tag(override_commit), | ||
| f"commit override instead of latest release ({previous_published_version})", | ||
| ) | ||
| # return ( |
Contributor
There was a problem hiding this comment.
nit: How soon are we thinking of uncommenting this code? If not soon, feels weird to have no separation between the TODO comment and the commented code itself.
SangJunBak
approved these changes
Nov 7, 2025
Contributor
SangJunBak
left a comment
SangJunBak
left a comment
There was a problem hiding this comment.
If we're just overriding the benchmarks to use tag "None" instead of a specific commit gc28d0061a6c9e63ee50a5f555c5d90373d006686, this looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #34021
Seen in https://buildkite.com/materialize/nightly/builds/13985#019a53a4-7545-4043-8a33-7d85ad85023d
The root cause is that we now use LTO Release builds only for releases + nightly, not for normal test runs. So the tagged runs from test pipeline are all Optimized builds, comparing against them for performance doesn't make sense.
A better fix would be to make Nightly tag the release builds with a special tag, then use those tags in the comparison.
Test run: https://buildkite.com/materialize/nightly/builds/14001
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.