HOMING_CURRENT: fix M920 display - #28519
Open
narno2202 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Always with the Bigtreetech TFT refactoring, I noticed that when I parse
M920response, there is an emptyM920line between the firstM920line which concerns X, Y or Z homing current and the next response lines if homing current exists for other steppers. This is related to an empty call tosay_M920(forReplay).If you set homing current but not
SENSORLESS_HOMING,M920is empty. The code is guarded inM920_report()by axis (stepper)HAS_SENSORLESSbut sensorless homing is not mandatory to set a homing current. Change the guards to axis (stepper)HAS_HOME_CURRENT.Requirements
Benefits
M920 displays what is expected
Configurations
Related Issues