Skip to content

Added support for orange and bgOrange#142

Open
abhishekc-sharma wants to merge 1 commit intoMarak:masterfrom
abhishekc-sharma:master
Open

Added support for orange and bgOrange#142
abhishekc-sharma wants to merge 1 commit intoMarak:masterfrom
abhishekc-sharma:master

Conversation

@abhishekc-sharma
Copy link
Copy Markdown

Fixes #123

@petrosagg
Copy link
Copy Markdown

+1, halloween is near

@ryanmurakami
Copy link
Copy Markdown

+1

@mikeerickson
Copy link
Copy Markdown

Was this ever merged?

@mikeerickson
Copy link
Copy Markdown

@portgasd666 Was this ever merged? If not, is there a branch which has this added?

@ORESoftware
Copy link
Copy Markdown

somebody click "merge"

@Andrews54757
Copy link
Copy Markdown

Doesnt work for my computer. And ansi code 38 is fully supported for my machine

@DABH
Copy link
Copy Markdown
Contributor

DABH commented Feb 12, 2018

Is there some reason orange isn't always supportable? See comments at bottom of #123 ... generally this seems like it should be merged, but feels like a little extra clarity is needed (either here, in the docs, etc.) about why orange is different and why it might/might not work in different environments...

@ORESoftware
Copy link
Copy Markdown

@Marak please merge thx

@DABH
Copy link
Copy Markdown
Contributor

DABH commented Feb 14, 2018

Orange is not an ANSI color, would something like #76 be preferred? (Just all-out support custom colors... why stop at orange...)

@Marak
Copy link
Copy Markdown
Owner

Marak commented Feb 14, 2018

I'm guessing if certain colors and styles work on some systems ( but not all systems ), we should consider adding the API methods.

For example, if orange method is supported for some shells we should allow that color. If a user attempts to use orange in a non-supported environment, we could produce a warning message based on feature detection of the environment.

I'm guessing for additional colors we'll want to add true color / 24 bit color mode. Maybe look at https://github.com/irisli/fullcolor for inspiration. Might make sense to wrap all this under that functionality.

@Marak
Copy link
Copy Markdown
Owner

Marak commented Feb 14, 2018

see: https://gist.github.com/XVilka/8346728 for more details

@mesqueeb
Copy link
Copy Markdown

+1 for orange!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants