Skip to content

Disable prototype methods when disabled#112

Open
EricMCornelius wants to merge 1 commit intoMarak:masterfrom
EricMCornelius:master
Open

Disable prototype methods when disabled#112
EricMCornelius wants to merge 1 commit intoMarak:masterfrom
EricMCornelius:master

Conversation

@EricMCornelius
Copy link
Copy Markdown

Currently the prototype additions to string don't seem to be disabled appropriately when not in a tty session. Following test case demonstrates:

ecornelius@ecornelius-T5-XE ~/Repositories/Posh % cat test.js 
#!/usr/bin/env node

var colors = require('colors');
console.log(colors.enabled);

console.log('test'.red);

ecornelius@ecornelius-T5-XE ~/Repositories/Posh % ./test.js 
true
test [red]

ecornelius@ecornelius-T5-XE ~/Repositories/Posh % ./test.js --no-color
false
test [red]

Currently the prototype additions to string don't seem to be disabled appropriately when not in a tty session.  Following test case demonstrates:

```
ecornelius@ecornelius-T5-XE ~/Repositories/Posh % cat test.js 
#!/usr/bin/env node

var colors = require('colors');
console.log(colors.enabled);

console.log('test'.red);

ecornelius@ecornelius-T5-XE ~/Repositories/Posh % ./test.js 
true
test [red]

ecornelius@ecornelius-T5-XE ~/Repositories/Posh % ./test.js --no-color
false
test [red]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant