Add support for font features and variants #4431
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR adds support for font features and font variants in text elements rendered with Pango. It relies on changes in ManimCommunity/ManimPango#121. When using versions of ManimPango that don't support font features or variants (like, the latest release) this has no effect, thanks to wrapping attr setters using
with suppress(Exception)
.Motivation and Explanation: Why and how do your changes improve the library?
Looking at the
CountingScene
example in the docs, I noticed that the layout shifting horizontally as the numbers were incrementing. I went to update the example to use tabular instead of proportional figures, but didn't see a way to do that.Digging in further, I found a way to do this in LaTeX (I think... PR forthcoming), but not for SVG text. This led me down a rabbit hole that resulted in ManimCommunity/ManimPango#121 and now this PR.
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist