add skip_update as a replacement for returning nothing in ComputePipeline callbacks - #5754
Draft
ffreyer wants to merge 4 commits into
Draft
add skip_update as a replacement for returning nothing in ComputePipeline callbacks#5754ffreyer wants to merge 4 commits into
skip_update as a replacement for returning nothing in ComputePipeline callbacks#5754ffreyer wants to merge 4 commits into
Conversation
Collaborator
Author
|
/benchmark 20 |
Collaborator
Benchmark ResultsSHA: eb33c7e6de6ec169614ebe0c157b384993640007 · 20 samples Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is mostly in response to #5717 (comment)
Currently edge callbacks can return
nothingto mark all outputs or a specific output as "not updated". This can be problematic when an output is fixed toUnion{Nothing, ...}as it makes it impossible to switch tonothing. This pr addsstruct SkipUpdate endand an exportedconst skip_update = SkipUpdate()to fix this.Note that this can't be deprecated cleanly because the old and new use of
nothingcan't be differentiate. So instead I added a Preferneces.jl based global to enable/disable warnings. These also give a bunch of information about the edge to hopefully make it easier to find the actual issue.I also deprecated some special casing for edge initialization which allows
return nothingto initialize all outputs rather than the usual on value per output. I don't see whynothingshould be treated differently here.Type of change
Checklist