Conversation
…g so that errors are properly handled
pleb
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Before this change, errors thrown from
verifyMultiIssuer(and presumablyverifyForHost) are not caught by the inlinecatchcallback.Instead of calling the
unauthorizedResponserequest handler, the default Express error handler is called, resulting in a500response instead of401(or whateverunauthorizedResponseis written to do).This is presumably because:
RequestHandler(middleware functions)verifyMultiIssuerandverifyForHostdo not return a promise, even though they have async callscatchcallbackTesting
catchdoes not run or is run after the default Express error handler)catchclause is run andunauthorizedResponsesets the response to401)Also
Upgrade packages, mostly dev deps