refactor: Major code quality improvements and bug fixes#14
Merged
Abourass merged 1 commit intoNov 18, 2025
Merged
Conversation
- Change Node engine constraint to >=25 - Fix critical rule assignment bugs where entire rules object was assigned instead of filtered rules - Fix disabled rules merging to properly append instead of replace - Remove duplicate @typescript-eslint/no-var-requires from disabled rules list - Remove browserslist config (not applicable for Node.js package) - Replace console.info with proper LintGolemError throwing in init() method - Refactor to use static readonly constants for all default rules - Make all instance properties readonly to reduce mutable state - Add comprehensive validation: - Validate rootDir exists and is a directory - Validate all tsconfigPaths files exist - Validate ecmaVersion values - Add new validation tests - Update test suite to use real paths instead of fake paths - Remove unused eslint-disable directives All tests passing (23 tests, 90.9% coverage) All linting and type-checking passing
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Abourass
deleted the
claude/repo-analysis-feedback-016ZpvhUWNr68z8CdsLMzAES
branch
November 18, 2025 17:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests passing (23 tests, 90.9% coverage)
All linting and type-checking passing