Skip to content

small zbmath fixes#210

Merged
LizzAlice merged 1 commit intomainfrom
zbmath_fixes
Mar 3, 2026
Merged

small zbmath fixes#210
LizzAlice merged 1 commit intomainfrom
zbmath_fixes

Conversation

@LizzAlice
Copy link
Contributor

@LizzAlice LizzAlice commented Mar 3, 2026

small zbmath fixes

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Journal names now display with consistent spacing, removing extra whitespace.
    • Improved error handling during DOI information retrieval for better system resilience.

@LizzAlice LizzAlice requested a review from eloiferrer March 3, 2026 14:46
@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Two modifications to the ZBMath importer: normalizing journal names by collapsing whitespace, and expanding exception handling in DOI information retrieval to catch non-HTTPError exceptions while re-raising non-HTTPStatusError types.

Changes

Cohort / File(s) Summary
Journal Name Normalization
mardi_importer/mardi_importer/zbmath/ZBMathJournal.py
Modified __init__ to collapse multiple internal whitespace into single spaces alongside trimming, using " ".join(name.strip().split()) instead of name.strip().
Exception Handling Enhancement
mardi_importer/mardi_importer/zbmath/misc.py
Added general exception handler in get_info_from_doi to catch non-HTTPError exceptions; logs and continues if exception name contains "HTTPStatusError", otherwise re-raises.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • docker-importer#209: Also modifies ZBMathJournal.__init__, though with different initialization logic rather than name normalization.

Suggested reviewers

  • eloiferrer

Poem

🐰 A whitespace whisper, spaces collapsed with care,
Exception handlers catching errors in the air,
Journal names pristine, no double spacing here,
ZBMath importer runs ever more clear!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'small zbmath fixes' is vague and generic, using non-descriptive terms that don't clearly convey what specific changes were made to the zbmath module. Provide a more specific title that describes the actual changes, such as 'Normalize journal names and improve error handling in zbmath' or similar.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch zbmath_fixes

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LizzAlice LizzAlice merged commit 09a81fd into main Mar 3, 2026
1 of 2 checks passed
@LizzAlice LizzAlice deleted the zbmath_fixes branch March 3, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants