Add python 3.13 #593
Add python 3.13 #593
Conversation
|
@altheaden, could you have a quick look here and make sure I didn't miss anything? |
|
I'm also adding python 3.13 support on conda-forge here: |
| channel-priority: strict | ||
| auto-update-conda: true | ||
| python-version: ${{ matrix.python-version }} | ||
| python-version: 3.12 |
There was a problem hiding this comment.
Apparently conda-build isn't available for python 3.13 yet. That's fine, we don't need to build with the full python matrix, we just need the package that gets built to use the full python matrix.
xylar
force-pushed
the
add-python-3.13
branch
from
d384635 to
3b35c6f
Compare
| matrix: | ||
| python-version: ["3.9", "3.10", "3.11", "3.12"] | ||
| python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] | ||
| fail-fast: false |
There was a problem hiding this comment.
@altheaden, I've been seeing CI get cancelled when one job in the matrix fails. I think this (rather than cancel_others: false below) might be the fix.
Could you add this on other repos when you do other updates?
| conda create -y -n mpas_tools_dev --use-local mpas_tools \ | ||
| python=${{ matrix.python-version }} \ | ||
| conda create -y -n mpas_tools_dev -c ${CONDA_PREFIX}/conda-bld/ \ | ||
| -c conda-forge mpas_tools python=${{ matrix.python-version }} \ |
There was a problem hiding this comment.
I'm not sure why python 3.13 likes this better but I'll take it...
|
Looks good to me! If you would like me to do any testing myself, let me know. Otherwise, I think it looks fine to merge. |
|
Thanks, @altheaden |
xylar
added
ci
2 participants
No description provided.