Skip to content

Conversation

@cbegeman
Copy link
Contributor

@cbegeman cbegeman commented Nov 8, 2024

This is basically a direct port of the barotropic streamfunction calculation from MPAS-Analysis, just making prefix an argument to compute_transport so that either time monthly averaged or instantaneous output can be used.

This PR also includes minor formatting in the mpas_tools.ocean.depth routines.

@cbegeman cbegeman requested a review from xylar November 8, 2024 16:16
@cbegeman cbegeman self-assigned this Nov 8, 2024
@xylar xylar assigned xylar and unassigned cbegeman Nov 12, 2024
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbegeman, this looks good. Can you add it to the documentation and the API? I think there are some examples to work from.

@xylar
Copy link
Collaborator

xylar commented Nov 12, 2024

In the meantime, I'll make a PR so we can make a release once this branch gets merged.

@xylar
Copy link
Collaborator

xylar commented Nov 13, 2024

@cbegeman, I'm going to take a crack at documentation. I hope you don't mind.

@xylar
Copy link
Collaborator

xylar commented Nov 13, 2024

I successfully built the docs locally, and they looked as expected.

@xylar xylar merged commit 2dbd9de into MPAS-Dev:master Nov 13, 2024
4 checks passed
@xylar
Copy link
Collaborator

xylar commented Mar 6, 2025

@cbegeman, since bugs have been found in the BSF in MPAS-Analysis, we should redo this port in the near future.

MPAS-Dev/MPAS-Analysis#1069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants