-
Notifications
You must be signed in to change notification settings - Fork 53
Allow time series tasks to run when history files are not present but cached files are #1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow time series tasks to run when history files are not present but cached files are #1126
Conversation
… the history files exist or not
34b70af to
cda2fe1
Compare
|
@xylar Can you take a look at this when you have the chance? And also let me know if that failing check is an issue I need to address? This is the PR that I think is needed for the HR team and which would go into that shared conda env we discussed. |
|
This PR is conceptually related to E3SM-Project/zppy#760 in that we need to cache a few more files with zppy to allow MPAS-A to extend time series even when the history files are removed from disk. |
|
@cbegeman, I think this looks good. I will want to run a few tests once you're ready. I think the failing CI was probably just a glitch on anaconda.org. I've been seeing a lot of them today. |
|
@xylar Please do run whatever tests you have time for. I've been running a few tests with history files and cached files present vs. absent with a LR run on chrysalis but I may have missed conditions that could cause problems. |
|
I think it should be sufficient to run the dev test suite on Chrysalis as a do-no-harm test. Your changes look straightforward so I think your tests of the feature are almost certainly sufficient. |
Test SuiteI ran the The main vs. control run is still running but everything else looks good and I don't expect any trouble with that one. |
|
Happy to approve once this is out of draft mode. |
|
@xylar Thank you! Then I think it's ready for you to create a shared environment on chrysalis from this. |
What we did for BlueTip was to merge the PR(s) to develop and then create a tag from develop that was used for the install. The tags are named things like The environment would be an MPAS-Analysis development environment installed from the tag. |
xylar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
I'll go ahead and merge, and I'll make the tag, environment and load script tomorrow once I get confirmation on what you would like to have it be named. |
@xylar Thanks for pushing forward on this. Both of those names seem appropriate to me. |
Two changes were needed to allow time series tasks to run when history files are not present but cached files contain the relevant information for those time stamps:
Return a warning rather than an error if the history files are not present for an analysis task. If the time series output is present in the output file for a time series task, it will catch it at the
runstage and successfully use this output. Thus, we do not need to return an error at thesetup_and_checkstage.For the MOC time series, look for data between
startDateandendDate. Formerly, the task only looked for cached information corresponding to dates that were present in input history files.