Fix Linux build with Wayland enabled + Some changes#237
Conversation
| bool LinuxDisplayWayland::IsPrimary() const | ||
| { | ||
| return (this == LinuxWaylandState::GetDisplayList()[0]); | ||
| return (this == LinuxWaylandState::GetDisplayList()[0].get()); |
There was a problem hiding this comment.
Would it be better if we identified the display by its id (data_.name) instead of by the pointer?
There was a problem hiding this comment.
I'm not familiar with Wayland. Gemini suggests Wayland leaves the concept of a primary display up to the compositors and that a heuristic might be necessary like checking the position being at (0, 0). What name would you be looking for to detect the primary display?
LukasBanana
left a comment
LukasBanana
left a comment
There was a problem hiding this comment.
Looks good. I'll merge if you can please add a comment to the empty function body.
| } | ||
|
|
||
| void LinuxDisplay::ClearCache() | ||
| { |
There was a problem hiding this comment.
Can you please add a comment to empty functions that says "dummy" or an explanation why it's empty. This makes it clear they are empty on purpose.
2 participants
No description provided.