Skip to content

ci: UTLP-9 add GitHub Actions workflow for lint, format, and build#32

Open
vinhthomas41 wants to merge 11 commits intomainfrom
thomas/add-CI-checks
Open

ci: UTLP-9 add GitHub Actions workflow for lint, format, and build#32
vinhthomas41 wants to merge 11 commits intomainfrom
thomas/add-CI-checks

Conversation

@vinhthomas41
Copy link
Copy Markdown
Collaborator

Addresses #15 by creating ci checks for lint, format, and build (both chrome and firefox)

  • Updated lockfile as it was not updated with the package.json
  • Added globals dependency to package.json because eslint was trying to import globals but it was not present in package.json(I'm not too sure if this was okay to do or not)

Copy link
Copy Markdown
Collaborator

@VS-code-cloud VS-code-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Thomas, this looks pretty good!

One small thing: currently the Linting is failing because AISummary (in src/components/content/quick-actions/AISummary.tsx) is missing an @returns declaration, so it would be great if you could add a simple returns declaration like "@returns A JSX element representing the AI Summary dialog and trigger button."

Did you make a post to the pr-review channel? I didn't see one, so please make sure you make a post and ping reviewers in the future, as that's the typical format used to notify about a new pull request.

@VS-code-cloud VS-code-cloud changed the title ci: add GitHub Actions workflow for lint, format, and build ci: UTLP-9 add GitHub Actions workflow for lint, format, and build Apr 15, 2026
@linear
Copy link
Copy Markdown

linear bot commented Apr 15, 2026

@vinhthomas41
Copy link
Copy Markdown
Collaborator Author

Hey Thomas, this looks pretty good!

One small thing: currently the Linting is failing because AISummary (in src/components/content/quick-actions/AISummary.tsx) is missing an @returns declaration, so it would be great if you could add a simple returns declaration like "@returns A JSX element representing the AI Summary dialog and trigger button."

Did you make a post to the pr-review channel? I didn't see one, so please make sure you make a post and ping reviewers in the future, as that's the typical format used to notify about a new pull request.

Alright, got it! I see that there is a signature verification warning for merges and was thinking about trying to verify my past commits but it looks like a lot of effort. Should I just leave them unverified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants