build: Flagged module as sideEffects false to enhance tree shaking#355
Open
alanhe421 wants to merge 1 commit intoLogRocket:masterfrom
Open
build: Flagged module as sideEffects false to enhance tree shaking#355alanhe421 wants to merge 1 commit intoLogRocket:masterfrom
alanhe421 wants to merge 1 commit intoLogRocket:masterfrom
Conversation
alanhe421
changed the title
Author
|
Maybe you can help review the PR? and merge it. thanks. |
this repo seems inactive, so may be we should find a new one |
Author
ok. I created a branch for maintenance. It has also been published to npm, and can be used directly if needed. installnpm i @stacker/redux-logger links |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current v4 version already supports the ES module, so in order for webpack packaging to work properly for treeshaking, you should mark the sideEffects here.