Skip to content

feat: elastic bridge - interfaces - #32

Merged
paullla merged 2 commits into
Locastic:masterfrom
manuel-gamma:feature/elastic-interfaces
Jul 2, 2026
Merged

paullla merged 2 commits into
Locastic:masterfrom
manuel-gamma:feature/elastic-interfaces

Conversation

@manuel-gamma

Copy link
Copy Markdown
Contributor

Add ElasticsearchClientInterface & ElasticsearchServiceInterface for more flexibility (ex: service decoration).

add ElasticsearchClientInterface & ElasticsearchServiceInterface
@manuel-gamma
manuel-gamma force-pushed the feature/elastic-interfaces branch from 1b47ef0 to 3fddcaa Compare September 1, 2025 09:45
@manuel-gamma

Copy link
Copy Markdown
Contributor Author

Hi @paullla can you help me please ? Scrutinizer can't prepare the container, how can i resolve this ?

@paullla

paullla commented Sep 1, 2025

Copy link
Copy Markdown
Member

hey @manuel-gamma , it was a temporary error, I rerun it and it's all good now

@manuel-gamma

Copy link
Copy Markdown
Contributor Author

Hello,

Any feedbacks on this PR ?

Thanks

@paullla

paullla commented Jul 2, 2026

Copy link
Copy Markdown
Member

Hi @manuel-gamma, first of all, apologies for the long silence on this, and thank you for the patience (and the pings).
I've reviewed the PR and I like it. Typing consumers against ElasticsearchClientInterface/ElasticsearchServiceInterface instead of the concrete classes is exactly the direction we're heading: we're planning a pluggable storage layer for 2.0, with Elasticsearch as the first backend, and these interfaces are a natural first step toward it.
CI was broken for all PRs until today. I've updated your branch with the merged master and the test suite passes. Merging, thanks a lot for contributing!

@paullla
paullla merged commit 706e42f into Locastic:master Jul 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants