Skip to content

refactor(sponsors): SVG row layout logic#43

Closed
ReenigneArcher wants to merge 1 commit into
masterfrom
refactor/sponsors/svg-row-layout-logic
Closed

refactor(sponsors): SVG row layout logic#43
ReenigneArcher wants to merge 1 commit into
masterfrom
refactor/sponsors/svg-row-layout-logic

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Extracted row composition and filling logic into separate functions for improved readability and maintainability in sponsor SVG rendering. Also updated SVG markup and parsing for consistency. Added a tsconfig.json for TypeScript configuration.

This also fixes many sonarcloud issues.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Improves SVG gradient stop by adding offset, replaces deprecated xlink:href with href, and refactors SVG dimension extraction to use regex.exec and Number methods. Also fixes row centering logic and removes unnecessary variable initialization.
@ReenigneArcher ReenigneArcher force-pushed the refactor/sponsors/svg-row-layout-logic branch from b607e84 to faaa658 Compare November 1, 2025 23:26
@sonarqubecloud

sonarqubecloud Bot commented Nov 1, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ReenigneArcher ReenigneArcher deleted the refactor/sponsors/svg-row-layout-logic branch November 1, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant