Skip to content

fixed the described bug in #1927 #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+17 −2
Open

fixed the described bug in #1927 #1928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
edc62aa
change in conf
shumittaher Sep 2, 2025
bd08a22
fethcing col count dynamically
shumittaher Sep 2, 2025
fda26bb
active column count flowing to Section
shumittaher Sep 2, 2025
1f8ae2f
passed correct column span
shumittaher Sep 2, 2025
f7ab858
:adhesive_bandage: fixing bug reported in issue 1927
shumittaher Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/LinkItems/Section.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
:icon="icon"
:uniqueKey="groupId"
:collapsed="displayData.collapsed"
:cols="displayData.cols"
:cols="effectiveColsSpan"
:rows="displayData.rows"
:color="displayData.color"
:customStyles="displayData.customStyles"
Expand Down Expand Up @@ -128,6 +128,7 @@ export default {
widgets: Array,
index: Number,
isWide: Boolean,
activeColCount: String,
},
components: {
Collapsable,
Expand Down Expand Up @@ -209,6 +210,9 @@ export default {
}
return styles;
},
effectiveColsSpan() {
return Math.min(this.activeColCount, this.displayData.cols);
},
},
methods: {
/* Opens the iframe modal */
Expand Down
13 changes: 12 additions & 1 deletion src/views/Home.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
</router-link>
</div>
<!-- Main content, section for each group of items -->
<div v-if="checkTheresData(sections) || isEditMode" :class="computedClass">
<div v-if="checkTheresData(sections) || isEditMode" :class="computedClass"
ref="sectionsContainer">
<template v-for="(section, index) in filteredSections">
<Section
:key="index"
Expand All @@ -36,6 +37,7 @@
@change-modal-visibility="updateModalVisibility"
:isWide="!!singleSectionView || layoutOrientation === 'horizontal'"
:class="(searchValue && section.filteredItems.length === 0) ? 'no-results' : ''"
:activeColCount="activeColCount"
/>
</template>
<!-- Show add new section button, in edit mode -->
Expand Down Expand Up @@ -83,6 +85,7 @@ export default {
layout: '',
itemSizeBound: '',
addNewSectionOpen: false,
activeColCount: '1',
}),
computed: {
singleSectionView() {
Expand Down Expand Up @@ -172,12 +175,20 @@ export default {
availibleThemes.Default = '#';
return availibleThemes;
},
readActiveColCount() {
const { sectionsContainer } = this.$refs;
if (!sectionsContainer) return;
const cs = getComputedStyle(sectionsContainer);
const varVal = cs.getPropertyValue('--col-count').trim();
this.activeColCount = varVal;
},
},
mounted() {
this.initiateFontAwesome();
this.initiateMaterialDesignIcons();
this.layout = this.layoutOrientation;
this.itemSizeBound = this.iconSize;
this.readActiveColCount();
},
};
</script>
Expand Down