Demo: Fix hardcoded CUDA references to support Apple Silicon MPS and fix input_sample_rate#30
Open
kainoj wants to merge 2 commits into
Open
Demo: Fix hardcoded CUDA references to support Apple Silicon MPS and fix input_sample_rate#30kainoj wants to merge 2 commits into
kainoj wants to merge 2 commits into
Conversation
Auto-detect available device (cuda → mps → cpu) in the demo and pass it through to model/processor loading. Work around safetensors not supporting MPS as a direct load target by loading Mimi weights to CPU first when the target device is neither cpu nor cuda. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Chrome sends audio at 48kHz over WebRTC. Setting input_sample_rate=24_000 caused a needless 48->24->16kHz double resample before the conformer encoder. Using 48_000 lets torchaudio resample directly to 16kHz in one step. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
the device is neither cpu nor cuda
48→24→16kHz double resample before the conformer encoder (which expects 16kHz).
Test plan
liquid-audio-demoon Apple Silicon Mac — should load and run on MPS without errors