Refactor gallery generator with class-based architecture#50
Merged
Conversation
Introduces gallery_generator_v2.py alongside the original (kept for reference).
New classes:
- BookRepo: owns all remote fetching for one CSV row — normalizes fields,
fetches _config.yml / chapter_meta.yml / TOC / thumbnail, runs chapter
normalization, and accumulates master tags
- GalleryCard (ABC): shared truncation helper and abstract render()
- RepoCard(GalleryCard): built from BookRepo via from_book_repo(); handles
published badge from the CSV boolean (not from aggregated tags)
- ChapterCard(GalleryCard): built from BookRepo + normalized chapter dict;
per-language badge colors; computes tag_class_str before removing 'notebook'
Key behavioral contracts preserved:
- published stays a separate bool; BookRepo.tags never contains it
- standalone detection uses substring check ('standalone' in content_type)
- empty-title repos are skipped before card creation
- modal HTML is still discarded; only the static backdrop is written
Also fixes a silent mutation bug where the original panel functions popped
keys from the live tags dict reference.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces gallery_generator_v2.py alongside the original (kept for reference).
New classes:
Key behavioral contracts preserved:
Also fixes a silent mutation bug where the original panel functions popped keys from the live tags dict reference.