Skip to content

Conversation

@georgi-l95
Copy link
Member

@georgi-l95 georgi-l95 commented Oct 15, 2025

Summary by CodeRabbit

  • Chores
    • Updated release workflow to derive the Docker image version from build metadata for all release steps.
    • Standardized version usage when extracting binaries for x86_64 and arm64 and when pulling release images.
    • Aligned asset upload process to use the same version source for consistency.
    • Improves reliability and consistency of the release process; no user-facing changes.

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 self-assigned this Oct 15, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 15, 2025

Walkthrough

The release workflow updates references to the image version, switching from github.event.release.tag_name to steps.meta.outputs.version for Docker pulls, binary extraction (x86_64/arm64), and the release asset upload process. No other steps, conditions, or error handling are changed.

Changes

Cohort / File(s) Summary
Release workflow version sourcing
\.github/workflows/release.yml
Replace uses of github.event.release.tag_name with steps.meta.outputs.version in Docker image pull, binary extraction for x86_64 and arm64, and release asset upload commands.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant GH as GitHub Actions Runner
  participant Meta as Metadata Step
  participant Reg as Docker Registry
  participant Ext as Extract Binaries
  participant Up as Upload Release Assets

  GH->>Meta: Run metadata action
  Note over Meta: Produce steps.meta.outputs.version
  GH->>Reg: docker pull image:<version from Meta>
  Reg-->>GH: Image for derived version
  GH->>Ext: Extract x86_64 and arm64 binaries
  Ext-->>GH: Artifacts
  GH->>Up: Upload assets using derived version
  Note over GH,Up: Version sourced from steps.meta.outputs.version
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • improve release workflow #124 — Also modifies .github/workflows/release.yml around Docker image extraction/packaging; closely related to version sourcing changes in this PR.

Poem

A bunny taps the version key,
Not from the tag, but meta’s decree.
Pull, extract, hop—so clean, so keen,
Two arches packed, a tidy scene.
Carrots for CI, releases for thee! 🥕🚀

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is entirely missing and does not follow the required template, omitting the “Description,” “Related Issues,” “Changes,” and “Reviewer Checklist” sections specified by the repository guidelines. Please add a pull request description following the provided template, including a concise description of the change, related issue references, a detailed summary of the changes, and the reviewer checklist.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “chore: improve release workflow” succinctly and accurately conveys the primary change of enhancing the release workflow, is concise and focused, and avoids unnecessary detail or noise.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch improve-release-workflow

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84b60c8 and 162fc9e.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build and Basic Quality Checks
  • GitHub Check: Security Audit
🔇 Additional comments (1)
.github/workflows/release.yml (1)

69-75: Check non-semver tags before using steps.meta.outputs.version
We simulated a non-semver tag (release-2025-10) but saw no version output; please inspect the full /tmp/meta.log (or rerun with DEBUG) to confirm whether steps.meta.outputs.version is empty for non-semver tags, and either enforce semver-compatible tags or add a fallback to github.event.release.tag_name.


Comment @coderabbitai help to get the list of available commands and usage tips.

@georgi-l95 georgi-l95 merged commit 83e1f33 into main Oct 15, 2025
6 checks passed
@georgi-l95 georgi-l95 deleted the improve-release-workflow branch October 15, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants