Synchronize gradients in manual optimization with DDPStrategy(static_graph=True) #21251
+69
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes gradient synchronization when using manual optimization with
DDPStrategy(static_graph=True)
.reducer._delay_all_reduce()
inpost_backward
to ensure gradients are properly reduced in the first iteration.test_ddp_gradients_synced
) that checks gradient synchronization across:automatic_optimization=True
/False
static_graph=True
/False
Fixes #18086
Before submitting
Yes
yes
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21251.org.readthedocs.build/en/21251/