Skip to content

Conversation

@bhimrazy
Copy link
Collaborator

What does this PR do?

Removes torchaudio dependency (to perform minimal tasks in tests) and update audio processing to use soundfile

Follow up to #738

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy self-assigned this Oct 21, 2025
@bhimrazy bhimrazy requested a review from deependujha October 21, 2025 08:44
@bhimrazy bhimrazy changed the title ref(test): remove torchaudio dependency and update audio processing to use soundfile ref(test): remove torchaudio dependency and update audio processing to just use soundfile Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80%. Comparing base (359bbf1) to head (56f0216).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #739   +/-   ##
===================================
- Coverage    80%    80%   -0%     
===================================
  Files        52     52           
  Lines      7330   7329    -1     
===================================
- Hits       5869   5867    -2     
- Misses     1461   1462    +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tchaton tchaton merged commit a249a28 into Lightning-AI:main Oct 24, 2025
36 checks passed
@bhimrazy bhimrazy deleted the chore/drop-torchaudio-dependency branch October 24, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants