Add type argument to descriptor __get__ #2754
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shino16
force-pushed
the
fix-2677-segfault
branch
from
cf51fcd to
ccbc0ad
Compare
Copilot finished reviewing on behalf of
shino16
November 18, 2025 23:00
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a CPython segfault issue (python/cpython#132747) by correctly calling the descriptor protocol's __get__ method with both required arguments. The change ensures that when unbinding builtin methods, the type argument is explicitly passed to __get__.
- Modified the descriptor
__get__call to include the type argument:__get__(slf, type(slf))instead of__get__(slf)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kshitij12345
approved these changes
Nov 19, 2025
Collaborator
kshitij12345
left a comment
kshitij12345
left a comment
There was a problem hiding this comment.
Great, thanks @shino16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
_call_dispatchuse__get__(slf, type(slf))instead of__get__(slf), working around a CPython segfault (python/cpython#132747).This will eliminate the segmentation fault mentioned in #2677 (comment). From Python 3.13.3 this workaround will no longer be necessary, but I think we can keep it anyway.