-
Notifications
You must be signed in to change notification settings - Fork 108
Run test_dtensor with torchrun #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8d40b21
to
7cf40ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can you clarify the context? What makes it hard for nvFuser DTensor tests to work with DistributedParallelTestCase?
(Have also added this to PR description)
I was seeing hang-up in some tests when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kshitij12345
we can just run |
Context:
When running the
test_dtensor.py
like we do now (pytest thunder/tests/distributed/test_dtensor.py
), we seeError from segmentation group 1: The singleton Communicator isn't available.
for #2503Changes:
class DTensorTest(DistributedParallelTestCase)
to free functions withtest
prefix and run the test withtorchrun --nproc-per-node 2 --no-python pytest thunder/tests/distributed/test_dtensor.py
(This is required to correctly run the nvFuser tests)cc @Borda