feat: unified search #6243
Merged
feat: unified search #6243
+197
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any97Cris
force-pushed
the
feat/unified-search
branch
from
278e4ba to
0dd4d80
Compare
vitormattos
requested changes
Dec 22, 2025
Any97Cris
force-pushed
the
feat/unified-search
branch
from
0dd4d80 to
85ed9f6
Compare
vitormattos
requested changes
Dec 22, 2025
Any97Cris
force-pushed
the
feat/unified-search
branch
from
85ed9f6 to
d8263f7
Compare
samuelsonbrito
requested changes
Dec 24, 2025
lib/Db/SignRequestMapper.php
Outdated
| $qb = $this->getFilesAssociatedFilesWithMeQueryBuilder($user->getUID(), $filter, false, $sort); | ||
|
|
||
|
|
||
| $qb->orderBy('f.created_at', 'DESC'); |
Contributor
There was a problem hiding this comment.
Remove, it is no longer necessary. Row: 434
vitormattos
force-pushed
the
feat/unified-search
branch
from
d8263f7 to
cc89ce6
Compare
Member
|
I made a rebase with main branch to fix conflicts, only this. |
vitormattos
force-pushed
the
feat/unified-search
branch
2 times, most recently
from
585b325 to
608a303
Compare
vitormattos
reviewed
Jan 19, 2026
lib/Db/SignRequestMapper.php
Outdated
| $qb = $this->getFilesAssociatedFilesWithMeQueryBuilder($user->getUID(), $filter, false, $sort); | ||
|
|
||
|
|
||
| $qb->orderBy('f.created_at', 'DESC'); |
Member
There was a problem hiding this comment.
Look, now the $sort is sent at row 431 but here is defined again. This row should be removed now
Suggested change
| $qb->orderBy('f.created_at', 'DESC'); |
lib/Db/SignRequestMapper.php
Outdated
| } | ||
|
|
||
| private function getFilesAssociatedFilesWithMeQueryBuilder(string $userId, array $filter = [], bool $count = false): IQueryBuilder { | ||
| private function getFilesAssociatedFilesWithMeQueryBuilder(string $userId, array $filter = [], bool $count = false, array $sort = []): IQueryBuilder { |
Member
There was a problem hiding this comment.
When a function has many arguments, it's advisable to split them into multiple rows. This approach preserves the git log, allowing changes related to added or removed arguments to be clearer and more isolated. If all arguments are on a single line, adding or removing an argument can lead to a commit that alters the entire line. Consequently, running git blame will not make it easy to see changes related to individual arguments.
Suggested change
| private function getFilesAssociatedFilesWithMeQueryBuilder(string $userId, array $filter = [], bool $count = false, array $sort = []): IQueryBuilder { | |
| private function getFilesAssociatedWithMeQueryBuilder( | |
| string $userId, | |
| array $filter = [], | |
| bool $count = false, | |
| array $sort = [], | |
| ): IQueryBuilder { |
lib/Search/FileSearchProvider.php
Outdated
|
|
||
| $searchResultEntry = new SearchResultEntry( | ||
| $thumbnailUrl, | ||
| $file->getName() ?? $this->l10n->t('Unnamed document'), |
Member
There was a problem hiding this comment.
Name is mandatory
Suggested change
| $file->getName() ?? $this->l10n->t('Unnamed document'), | |
| $file->getName(), |
lib/Search/FileSearchProvider.php
Outdated
| } | ||
|
|
||
| private function formatResult(File $file, IUser $user): SearchResultEntry { | ||
| $userFolder = $this->rootFolder->getUserFolder($user->getUID()); |
Member
There was a problem hiding this comment.
Suggested change
| $userFolder = $this->rootFolder->getUserFolder($user->getUID()); | |
| $userFolder = $this->rootFolder->getUserFolder($file->getUserId()); |
Any97Cris
force-pushed
the
feat/unified-search
branch
from
3a213a2 to
2337ff9
Compare
vitormattos
approved these changes
Jan 20, 2026
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Signed-off-by: Crisciany Souza <crisciany.souza@librecode.coop>
Any97Cris
force-pushed
the
feat/unified-search
branch
from
7bb8e56 to
a4a76d9
Compare
Member
|
/backport to stable32 |
Member
|
/backport to stable31 |
This was referenced Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6027
✨ Features
Global Search Integration: Documents can now be found using Nextcloud's unified search
Smart Filtering: Search by document name with automatic filtering
Rich Results: Display document thumbnails, file paths, and signature status
Status Labels: Show document status (Draft, Able to sign, Partially signed, Signed, Deleted)
Dynamic Icons: Automatically detect and display appropriate MIME type icons
Pagination Support: Handle large result sets efficiently