Feature/#757 add stroke style properties #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er props utils with default strokeWidth value
…laceholder and text scribbled
…into respective components
brauliodiez
reviewed
Apr 21, 2025
| @@ -0,0 +1,61 @@ | |||
| import { ShapeType } from '@/core/model'; | |||
| import { AdjustedShapeDimensions } from './shape-dimension-types'; | |||
| export const calculateShapeAdjustedDimensions = ( | |||
Member
There was a problem hiding this comment.
Rename this to:
calculateShapeAdjustedDimensionsBasedOnStrokeHeightWhy this long name? Because in this case we need to be explicit when we get into this function, if not it would be hard to check what's the purpose of this function.
On the other hand, could you add unit tests to check that the function behaves as expected?
Thanks
…nsionsBasedOnStrokeHeight and update imports
…and use centerX and centerY for calculations in ellipseLow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #757