Skip to content

Only save feature properties when actually needed #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
perliedman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only save feature properties when actually needed #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions src/Leaflet.VectorGrid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,16 +159,20 @@ L.VectorGrid = L.GridLayer.extend({
},

_createLayer: function(feat, pxPerExtent, layerStyle) {
var options = {
storeProperties: this.options.getFeatureId
};
var layer;

switch (feat.type) {
case 1:
layer = new PointLayer(feat, pxPerExtent);
layer = new PointLayer(feat, pxPerExtent, options);
break;
case 2:
layer = new PolylineLayer(feat, pxPerExtent);
layer = new PolylineLayer(feat, pxPerExtent, options);
break;
case 3:
layer = new PolygonLayer(feat, pxPerExtent);
layer = new PolygonLayer(feat, pxPerExtent, options);
break;
}

Expand Down Expand Up @@ -225,8 +229,10 @@ var PointLayer = L.CircleMarker.extend({
iconCache: {}
},

initialize: function(feature, pxPerExtent) {
this.properties = feature.properties;
initialize: function(feature, pxPerExtent, options) {
if (options.storeProperties) {
this.properties = feature.properties;
}
this._makeFeatureParts(feature, pxPerExtent);
},

Expand Down Expand Up @@ -332,8 +338,10 @@ var polyBase = {
var PolylineLayer = L.Polyline.extend({
includes: [FeatureLayer.prototype, polyBase],

initialize: function(feature, pxPerExtent) {
this.properties = feature.properties;
initialize: function(feature, pxPerExtent, options) {
if (options.storeProperties) {
this.properties = feature.properties;
}
this._makeFeatureParts(feature, pxPerExtent);
},

Expand All @@ -352,8 +360,10 @@ var PolylineLayer = L.Polyline.extend({
var PolygonLayer = L.Polygon.extend({
includes: [FeatureLayer.prototype, polyBase],

initialize: function(feature, pxPerExtent) {
this.properties = feature.properties;
initialize: function(feature, pxPerExtent, options) {
if (options.storeProperties) {
this.properties = feature.properties;
}
this._makeFeatureParts(feature, pxPerExtent);
},

Expand Down