feat: allow overriding CustomField dependencies via dependency_provider#263
Open
anzzyspeaksgit wants to merge 1 commit intoLancetnik:mainfrom
Open
feat: allow overriding CustomField dependencies via dependency_provider#263anzzyspeaksgit wants to merge 1 commit intoLancetnik:mainfrom
anzzyspeaksgit wants to merge 1 commit intoLancetnik:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for overriding
CustomFieldclasses and instances usingdependency_provider.override(), addressing #176.Problem
Closes #176
Currently, users are unable to override
CustomFields at runtime usingdependency_providerfor testing purposes.dependency_provider.override()crashes or has no effect when provided with aCustomFieldclass or instance.Solution
Modified
CallModel._solveand_asolveto intercept evaluations ofCustomFieldand apply mocked overrides fromprovider.overrides(checked by instance or type).Updated
Provider.overrideto skip callingbuild_call_modelonCustomFieldobjects to prevent instantiation/signature errors. Type annotations updated to acceptCustomField.Added tests in
test_overrides.pyto ensure bothCustomFieldclasses and specific instances can be safely overridden.Testing
field=True/Falsevariants.This PR was created with AI assistance.